Re: [dwm] less consistent codestyle pull request

From: Diego Biurrun <diego_AT_biurrun.de>
Date: Wed, 14 May 2008 18:41:11 +0200

On Tue, May 13, 2008 at 06:08:59PM +0200, Szabolcs Nagy wrote:
> On 5/13/08, Diego Biurrun <diego_AT_biurrun.de> wrote:
> > > XGrabButton(dpy, AnyButton, AnyModifier, c->win, False,
> > > - BUTTONMASK, GrabModeAsync, GrabModeSync, None, None);
> > > + BUTTONMASK, GrabModeAsync, GrabModeSync, None, None);
> >
> > Well, before it was indented to align with the XGrabButton call. This
>
> used tabs to achieve this which is wrong

You have an interesting concept of wrong. It was certainly intentional.

> > was consistently done in at most a few places and makes the code less
> > readable.
>
> no (it was consistently space only indenting in least places)

It was consistently aligned with the help of spaces and tabs. You have
undone that in your pull request.

Diego
Received on Wed May 14 2008 - 18:41:46 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 15:39:32 UTC