Re: [dwm] Urgency hook?

From: Jeremy O'Brien <obrien654j_AT_gmail.com>
Date: Wed, 19 Dec 2007 19:13:44 -0500

On Wed, Dec 19, 2007 at 06:29:26PM -0500, Jeremy O'Brien wrote:
> > > >
> > > > Do you mind posting the modified pull request for 4.7? ;)
> > > >
> > > > Thanks!
> > > >
> > >
> > > Hehe. My first pull request ever! I emulated the author's style of modifying
> > > the config.h file over the config.def.h. The changes are easily spotted
> > > however. Here goes!
> > >
> >
> > Wow, nice job for a first pull request!
> > However, I really think you should use config.def.h for config changes. You
> > don't want a pull request application to fail because somebody has a different
> > colorscheme in his config :)
> >
> > I am using the pull request right now... Since this is an integral wm feature and
> > not a wm-ui enhancement, I really think this is a good candidate for
> > inclusion in mainline dwm.
> >
> > Ritesh
> >
> >
>
> Here's an updated version that modifies config.def.h instead. Keep in
> mind I didn't write the pull request. Just want the author to retain credit.
> Also, I think Anselm expressed interest in putting this into mainstream
> dwm, so you may just see it there soon ;)
>
> --
> Jeremy O'Brien aka neutral_insomniac

It would help if I actually attached the pull request, and also posted it to
the discord server :P Try number two!

-- 
Jeremy O'Brien aka neutral_insomniac
GPG key: 0xB1140FDB http://pohl.ececs.uc.edu/~jeremy/jeremy.asc
WSL ambelina 2.6.22.9 #1 Zilog(R) Z80
processor 4MHz GNU/WSL

Received on Thu Dec 20 2007 - 01:13:54 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 15:12:55 UTC