On Thu, Jun 16, 2016 at 10:07 PM, Anselm R Garbe <garbeam_AT_gmail.com> wrote:
> On 16 June 2016 at 16:15, FRIGN <dev_AT_frign.de> wrote:
>> On Thu, 16 Jun 2016 07:27:58 +0200
>> Anselm R Garbe <garbeam_AT_gmail.com> wrote:
>>> I would suggest to use: <project>-<pull request title>-<short dropbox hash>-<YYMMDD>.pull request
>>
>> st-externalpipe-ea87104-160423.pull request
>>
>
> Well, fair enough. My final suggestion is then:
>
> <project>-<pull request title>-<YYYYMMDD>-<short hash>.pull request
This is inconsistent with the format used for pull requestes against release versions,
in that the project version and pull request title are intermixed. Right now for
pull requestes against releases:
<project>-<version>-<pull request_title>.diff
I think this is fine for pull requestes against release versions.
For pull requestes against other things I would revise your proposed format to:
<project>-<YYYYMMDD>-<short hash>-<pull request title>.diff
The hash is worth including to avoid possible confusion when there are
multiple commits on a single day or devs who forget to pull.
Alternately the pull request title could be put in front:
<pull request_title>-<project>-<version>.diff
<pull request_title>-<project>-<YYYYMMDD>-<short hash>.diff
I've just written a script that checks all the pull requestes for correct names and
successful application to the specified commit. As soon as the format is
completely agreed I'll send it to this list.
Britton
Received on Fri Jun 17 2016 - 20:01:43 CEST