On Thu, 29 Jan 2015 15:08:39 -0800
Rian Hunter <rian+suckmore-dev_AT_thelig.ht> wrote:
> When MODE_INSERT is set we'd shift characters on the same
> line forward before inserting our character in tputc().
> This did not account for wide characters where width != 1.
> This pull request makes it so we shift the correct amount.
> - if(IS_SET(MODE_INSERT) && term.c.x+1 < term.col)
> - memmove(gp+1, gp, (term.col - term.c.x - 1) * sizeof(Glyph));
> + if(IS_SET(MODE_INSERT) && term.c.x+width < term.col)
> + memmove(gp+width, gp, (term.col - term.c.x - 1) * sizeof(Glyph));
> In tputc(), when a character wasn't large enough to fit
> on the current line, we would call tnewline() to place it on
> the next line. Fortunately, we weren't resetting our glyph
> pointer and this caused memory corruption when a
> wide character (width == 2) was being written. This pull request
> resets our glyph pointer after calls to tnewline().
> + gp = &term.line[term.c.y][term.c.x];
> - if(term.c.x+width > term.col)
> + if(term.c.x+width > term.col) {
> tnewline(1);
> + gp = &term.line[term.c.y][term.c.x];
> + }
Hey Rian,
I tested both pull requestes and second them. Nice work!
However, next time, please attach the pull requestes
instead of inserting them so people with insane
mail clients can easily access them without hassle.
Happy vibing!
Cheers
FRIGN
--
FRIGN <dev_AT_frign.de>
Received on Fri Jan 30 2015 - 00:41:38 CET