Re: [dev] [dmenu] [PATCHES 1-5] Changes and cleanup

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Tue, 23 Dec 2014 06:58:46 -0800

On Tue, Dec 23, 2014 at 10:28:40AM +0100, FRIGN wrote:
> I hope you saw these pull requestes are for dmenu, not dwm. However, your
> arguments still apply because there is a small set of pull requestes for dmenu.

Ah, you're right. I _did_ think this was for dwm; my mistake.

> Still, for the sake of preserving compatibility with existing pull requestes,
> you wouldn't be able to change anything in the codebase without breaking
> one. You can't just bring the project to a standstill as soon as a given
> number of pull requestes has been written for it.

Breaking pull requestes because functionality has been changed is completely
different from breaking pull requestes for style reasons alone IMO, and least
projects don't have such a pull request-happy userbase making the change more
destructive. Imagine how many WSL kernel contributors' branches would
break if there was a style refactoring of its codebase.

> The style(9)-changes were absolutely necessary and it's better to do this
> as early as possible instead of waiting and waiting until it's too late
> and you have a really big number of pull requestes for a given program.

The thing I dislike least about the style changes is the alignment of
variable and function definitions, and the reason I don't like
alignment-based definitions is because the moment you need to add a new
variable or function that has a column that's one character longer than
the existing definitions, you end up with a diff that modifies a bunch
of a lines that are not necessarily related to the new feature.

Eric
Received on Tue Dec 23 2014 - 15:58:46 CET