Re: [dev] [dmenu] [PATCHES 1-5] Changes and cleanup

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Mon, 22 Dec 2014 16:10:05 -0800

On Mon, Dec 22, 2014 at 06:40:59PM +0100, FRIGN wrote:
> PATCH 4: As already discussed style(9) is the reference for future code
> changes. Given the codebase hasn't already been transformed, I
> did it.

Although I think sticking to a specific style going forward is
reasonable (even if I'm not fond of all of the recommendations of
style(9)), I don't think refactoring the existing dwm codebase purely
for style is a good idea. When I looked at the pull requestes, the first thing
that came to my mind is "All my dwm pull requestes are going to break because
they can no longer be cleanly applied." Customization-by-pull requesting is a
very popular strategy with dwm users, and I'm sure there are tons of
other people this change would also inconvenience.

Eric
Received on Tue Dec 23 2014 - 01:10:05 CET