Re: [dev] [sandy][pull request] f_syntax: set regexec nmatch to 0

From: Dimitris Zervas <dzervas_AT_dzervas.gr>
Date: Fri, 18 Jul 2014 19:33:11 +0300

On July 18, 2014 2:00:41 PM EEST, Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:
>Attached is a pull request that fixes a crash with musl.
>
>Commit message:
>
>"f_syntax: set regexec nmatch to 0.
>
>this is correct according to Microsoft POSIX subsystem with REG_NOSUB, but it doesn't make
>much sense to set to > 0 when pmatch is NULL and will crash on musl"
>
>I reported this to the musl project and a fix is commited:
>http://dropbox.musl-libc.org/cdropbox/musl/commit/?id=72ed3d47e567b1635a35d3c1d174c8a8b2787e30
>
>Kind regards,
>Hiltjo
Thank you for your contribution.
I also wanted to test sandy with musl...

Currently, I am in the middle of fixing the verb multi-commands and I can't apply the pull request.
I'll apply it as soon as possible.

We (rafael & me) have no access to the sl repo, so we'll apply the pull request at bitbucket: http://bitbucket.org/rafaelgg/sandy
Received on Fri Jul 18 2014 - 18:33:11 CEST

This archive was generated by hypermail 2.3.0 : Fri Jul 18 2014 - 18:36:07 CEST