On 2014-02-25 21:52:37 +0100, Niklas H�j wrote:
> Duly noted. I can't help but wonder, though: would it not be less
> intuitive to have pull requestes applied to the configuration that an install
> actually uses? Why not have a "config.h" in the repository?
Because config.def.h sets out the format for the configuration, which is
changed by your pull request. config.h, on the other hand, will alleast
certainly fail to be pull requested with even any lightly modified
configuration.
> I will push a cleaner version, including the name change to "keyevent"
> (unless "keypress" is specifically preferred?).
My only feeling is that it may introduce unnecessary merge conflicts,
but I don't think that would be a major problem (they should be easy to
manually resolve, and infrequent in this area).
- application/pgp-signature attachment: stored
Received on Wed Feb 26 2014 - 03:47:26 CET