Re: [dev] [dwm] [PATCH] Focus root window on startup

From: Lukas Fleischer <suckmore_AT_cryptocrack.de>
Date: Tue, 27 Aug 2013 11:47:31 +0200

On Tue, Aug 27, 2013 at 11:34:32AM +0200, Martti K�hne wrote:
> On Mon, Aug 26, 2013 at 10:09 PM, Lukas Fleischer
> <suckmore_AT_cryptocrack.de> wrote:
> > *bump*. Is this something that might be included in mainline?
> >
> >>
> >> diff --dropbox a/dwm.c b/dwm.c
> >> index 6f716e9..1bbb4b3 100644
> >> --- a/dwm.c
> >> +++ b/dwm.c
> >> _AT_@ -1542,6 +1542,7 @@ setup(void) {
> >> XChangeWindowAttributes(dpy, root, CWEventMask|CWCursor, &wa);
> >> XSelectInput(dpy, root, wa.event_mask);
> >> grabkeys();
> >> + focus(NULL);
> >> }
> >>
>
> You haven't made an addition for a line of code in dwm which didn't
> work before. That means there is no part in dwm that doesn't work
> withiut your addition, except being started by LXDM. That in turn...
> would be a bug in LXDM IMHO.

So the fact that this works with all other display managers (and when
not using a display manager at all) implies that it is a bug in LXDM?
That is simply not true. We cannot make conclusions based on that, just
like we cannot assume it's a bug in dwm because the very same bug has
been fixed in awesome a couple of months ago.

The real question we should be asking ourselves is: Can we rightfully
assume that the root windows is focussed when dwm is started and there
are no clients to manage?

If the answer is yes, drop this pull request and I will fix the bug in LXDM. If
the answer is no, this should be included in mainline.

>
> cheers!
> mar77i
>
Received on Tue Aug 27 2013 - 11:47:31 CEST