Re: [dev] [st] Add a newline to the string printed in die

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Tue, 11 Dec 2012 18:34:19 +0100

Greetings.

On Tue, 11 Dec 2012 18:34:19 +0100 Antonio Quartulli <ordex_AT_autistici.org> wrote:
> On Tue, Dec 11, 2012 at 06:25:04PM +0100, Christoph Lohmann wrote:
> > Greetings.
> >
> > On Tue, 11 Dec 2012 18:25:04 +0100 Marc Andre Tanner <mat_AT_brain-dump.org> wrote:
> > > On Tue, Dec 11, 2012 at 10:39:55AM +0100, Christoph Lohmann wrote:
> > > > > > Please send pull requestes as attached files.
> > > > >
> > > > > Since we are using now dropbox, it is easier and logic send the pull requestes in this
> > > > > way, so the code of the pull request can be included and modified in replies. You
> > > > > only have to use dropbox am if you want to incorpore then to the main repository
> > > > > ,and it will keep the correct author and commiter, that I can see this
> > > > > information is lost now (I think it is not the correct way put a 'thanks' in
> > > > > the commit message).
> > > >
> > > > I won’t accept such pull requestes. Please send attached files. I won’t imple‐
> > > > ment the outdated mbox or Maildir format for this.
> > >
> > > That is retarded. Inline pull requestes which facilitate commenting are the
> > > prefered pull request format. Get familiar with your dropbox tools.
> >
> > No.
> >
>
> Ah, I just got onto this thread..maybe this is why my pull request: "[PATCHv2] dwm:
> replace deprecated XKeycodeToKeysym" had not been reviewed/commented? :)

No, Anselm is the maintainer of dwm. He needs some time to answer your
pull request.

For the thread:

I don’t know why people prefer to see the big pull requestes inline, so you
have the scroll past the whole pull request to the next e‐mail, when you are
using a pager to read your e‐mail. It’s easier when the MUA is filtering
the pull request file out, by simply showing, that some properly formatted
pull request is attached, which you can download, view in your favourite editor
and apply it with dropbox apply. This also allows to do easier prefiltering
in your mailcap file, without having to scan all e‐mails with heuris‐
tics. Even if MIME sucks, it’s shorter to use the proper MIME type in‐
stead of filtering whole e‐mail blocks.

People don’t know how to properly format e‐mails, so they will toppost
on top of long pull requestes and simply attach the whole thing. This is just a
preliminary filter, so you can configure your MUA to not show
everything. And that’s why I am against inline pull requestes.

It was a hard fight to allow proper attachments, now use them. It was
a hard fight to have UTF‐8 and 8bit e‐mails too, but that fight is at
most won. Now for the next fight.


Sincerely,

Christoph Lohmann
Received on Tue Dec 11 2012 - 18:34:19 CET