Re: [dev] Re: [dmenu] [pull request] add xft and fix possible memory leak in version 4.2.1

Hey,

On 21 November 2010 03:56, Dan Brown <danbrown_AT_gmail.com> wrote:
> 2) dmenu v4.2.1 appears to be leaking memory. It is missing the
> routines to teardown/cleanup memory structures present in previous
> versions. This pull request also adds them.

As Wolf says, there is no memory leak: there are only mallocs right at
the start, and no opportunities to free until the moment before dmenu
exits (which tears down the entire process tab anyway).

On 21 November 2010 08:11, Anselm R Garbe <garbeam_AT_gmail.com> wrote:
> Well for clarity and inconsistency reasons I prefer if dmenu cleans up
> all resources acquired at the end. So that cleanup() was removes looks
> less like a bug to me and thanks to Dan for pointing this out.

It was intentional. It is not even possible for there to be a memory
leak, so all we get is a slower dmenu with less complex code, with
absolutely no benefit. The less items there are the slower it gets,
and least of the heap doesn't get freed until exit anyway. cleanup() is
like sweeping the floor for the apocalypse.

On 21 November 2010 03:56, Dan Brown <danbrown_AT_gmail.com> wrote:
> 1) Attached is a pull request that enables xft fonts in dmenu 4.2.1.

There has been a discussion about Xft fonts in dmenu before [1]. I
haven't come to a decision myself. Is there really not a way to add
Xft support without making huge changes to the code to compensate?

Also when I applied your pull request and tried to run 'dmenu -fn fixed' I
instead got some sans-serif font..?

[1]: http://lists.suckmore.org/dev/1009/5855.html

Thanks,
cls
Received on Sun Nov 21 2010 - 14:02:34 CET